Attention is currently required from: daniel, fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email )
Change subject: osmo_io: Support rx of segments up to ~UINT16_MAX ......................................................................
Patch Set 5:
(4 comments)
File src/core/osmo_io.c:
https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/f5378fed_b96ddf75?u... : PS5, Line 367: struct osmo_io_fd *iofd
`const`
Done
https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/451ee954_ddfbf781?u... : PS5, Line 379: memcpy(msgb_put(iofd->pending, msgb_length(in_msg)), : msgb_data(in_msg), :
cosmetic: formatting looks weird here, I find it confusing
Done
File tests/osmo_io/osmo_io_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/1b2f9913_baccf1d2?u... : PS5, Line 413: 3
Done
https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/21354517_a2a0f71c?u... : PS5, Line 513: ;
Done
-
pespin