Attention is currently required from: fixeria, laforge, pespin.
lynxis lazus has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41016?usp=email )
Change subject: Remove duplicate 3GPP-AAA-Server-Name definition and break 3-way circular
dependency
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS1:
I think that's something we should be doing in
general for all files, ie. […]
We have 2 different ways of doing this,
there is breaking the circle and also moving the common files into spec.dia and
spec_swx.dia
We can migrate the breaking circle also later if we want.
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41016?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Idb1a7f7588b751c59788e4d99cd1d86f1fd2b573
Gerrit-Change-Number: 41016
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 06 Sep 2025 19:11:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>