Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/40975?usp=email )
Change subject: ranap: Improve error handling in Rx RESET
......................................................................
Patch Set 1:
(1 comment)
File src/sgsn/gprs_ranap.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40975/comment/653d6af9_2c9269a9?us… :
PS1, Line 679: if (ies->presenceMask &
ERRORINDICATIONIES_RANAP_CN_DOMAININDICATOR_PRESENT) {
a reset without domain ie is valid and expect?
According to specs the field is marked as "O" (optional), hence also why
code from ASN1 files generates a PRESENT define for it.
I didn't look for exact causes for missing the IE, but in the event it is forgotten I
followed the "be permissive on Rx" here.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/40975?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I2a53e10c3903992a42d081e3ec300fbdb9b3c34c
Gerrit-Change-Number: 40975
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 28 Aug 2025 21:45:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>