Attention is currently required from: Hoernchen, fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-trx/+/32762 )
Change subject: transceiver: pass cfg struct instead of args
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File Transceiver52M/device/lms/LMSDevice.h:
https://gerrit.osmocom.org/c/osmo-trx/+/32762/comment/a140951c_cc660dbb
PS3, Line 110: LMSDevice(InterfaceType iface, const struct trx_cfg *cfg);
The only part of osmotrx that follow any style is the
ms subdirectory, everythting else is 15 years […]
so then let's please take the
opportunity (after this patch/series) to do that cosmetic re-formatting once
--
To view, visit
https://gerrit.osmocom.org/c/osmo-trx/+/32762
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I48386900d15ff4d770c70a4efc246d32f921904b
Gerrit-Change-Number: 32762
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Jul 2023 07:47:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment