Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38576?usp=email )
Change subject: hnbgw: Introduce test TC_cs_iu_release_req_rua_disconnect
......................................................................
Patch Set 5:
(2 comments)
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38576/comment/10f82671_9b45…
:
PS4, Line 1334: var MgcpCommand mgcp_cmd;
unused
Done
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38576/comment/49a81235_e7d5…
:
PS5, Line 1367: f_sleep(1.0);
should there be something after this sleep, or is it just to make sure the SUT is not in
an inconsistent state for the next test?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38576?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6782920c4a86d3311eb54239ab13a18e393c1ec0
Gerrit-Change-Number: 38576
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 31 Oct 2024 08:21:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>