Attention is currently required from: lynxis lazus.
Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email )
Change subject: irq: make default IRQ handler Dummy_Handler weak
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Patchset:
PS2:
you're modifying asf4 code anyway, what's the point having a weak-weak alias chain instead of just replacing the dummy handler and removing the old function from startup_same54.c? This is the one and only firmware, not mysterious code with other users of the dummy handler that might or might not override it...
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I544e9c84dd538bb744fb799904adc58f9d850465
Gerrit-Change-Number: 42224
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: Hoernchen
ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-CC: osmith
osmith@sysmocom.de
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Comment-Date: Wed, 11 Mar 2026 11:33:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes