[S] Change in osmo-bts[master]: osmo-bts-sysmo: mute PHY until OML is ready - gerrit-log

26 Jun 2023

Attention is currently required from: pespin.

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33457
)

Change subject: osmo-bts-sysmo: mute PHY until OML is ready
......................................................................

Patch Set 4:

(1 comment)

File src/osmo-bts-sysmo/l1_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/33457/comment/74c070bb_fc504ab0 
PS3, Line 1264: 			if (!trx->mo.opstart_success)
...
  IMHO you should move this trx_rf_lock up to line 1258

Done

...
  and you could even simply remove bts_update_status
since you are locking now immediatelly. 
trx_rf_lock does not set BTS_STATUS_RF_ACTIVE, only BTS_STATUS_RF_MUTE (see
mute_rf_compl_cb). So keeping it.

...
  Moreover, this "if
(!trx->mo.opstart_success)" doesn't make sense to me, since for sure OPSTART
is to be done far afterwards, you can simply drop the check. 
Done

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33457
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3
Gerrit-Change-Number: 33457
Gerrit-PatchSet: 4
Gerrit-Owner: osmith &lt;osmith(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Mon, 26 Jun 2023 14:14:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-MessageType: comment