Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33457 )
Change subject: osmo-bts-sysmo: mute PHY until OML is ready ......................................................................
Patch Set 4:
(1 comment)
File src/osmo-bts-sysmo/l1_if.c:
https://gerrit.osmocom.org/c/osmo-bts/+/33457/comment/74c070bb_fc504ab0 PS3, Line 1264: if (!trx->mo.opstart_success)
IMHO you should move this trx_rf_lock up to line 1258
Done
and you could even simply remove bts_update_status since you are locking now immediatelly.
trx_rf_lock does not set BTS_STATUS_RF_ACTIVE, only BTS_STATUS_RF_MUTE (see mute_rf_compl_cb). So keeping it.
Moreover, this "if (!trx->mo.opstart_success)" doesn't make sense to me, since for sure OPSTART is to be done far afterwards, you can simply drop the check.
Done
-
osmith