pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41015?usp=email ) Change subject: dia: restrict AVPs inherited from RFC4005 ...................................................................... dia: restrict AVPs inherited from RFC4005 Otherwise the "Service-Type" AVP is inherited and then may cause third modules indirectly inheriting to collide with their own "Service-Type" AVP. Change-Id: I8066303b766c3f9c40de7bc727e20c7f5f5e3ebc fiiiix nasreq Change-Id: Ibc11180489db6d86819ab17a5e7e92636dfed95e --- M dia/diameter_3gpp_ts29_212.dia M dia/diameter_3gpp_ts29_229.dia M dia/diameter_3gpp_ts32_299.dia M dia/diameter_rfc4072.dia 4 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/15/41015/1 diff --git a/dia/diameter_3gpp_ts29_212.dia b/dia/diameter_3gpp_ts29_212.dia index 031e64d..40417fc 100644 --- a/dia/diameter_3gpp_ts29_212.dia +++ b/dia/diameter_3gpp_ts29_212.dia @@ -30,7 +30,7 @@ @vendor 10415 3GPP @inherits diameter_gen_base_rfc6733 -@inherits diameter_rfc4005_nasreq +@inherits diameter_rfc4005_nasreq Framed-IP-Address Framed-IPv6-Prefix Called-Station-Id @inherits diameter_rfc4006_cc @inherits diameter_3gpp_base @inherits diameter_etsi_es283_034 diff --git a/dia/diameter_3gpp_ts29_229.dia b/dia/diameter_3gpp_ts29_229.dia index 62ac31f..c9f888c 100644 --- a/dia/diameter_3gpp_ts29_229.dia +++ b/dia/diameter_3gpp_ts29_229.dia @@ -25,7 +25,7 @@ @inherits diameter_gen_base_rfc6733 @inherits diameter_etsi_es283_035 Line-Identifier -@inherits diameter_rfc4005_nasreq +@inherits diameter_rfc4005_nasreq Framed-Interface-Id Framed-IP-Address Framed-IPv6-Prefix ;; only attributes required by other applications are defined diff --git a/dia/diameter_3gpp_ts32_299.dia b/dia/diameter_3gpp_ts32_299.dia index d6b020c..eee540c 100644 --- a/dia/diameter_3gpp_ts32_299.dia +++ b/dia/diameter_3gpp_ts32_299.dia @@ -25,7 +25,7 @@ @inherits diameter_gen_base_rfc6733 @inherits diameter_gen_acct_rfc6733 -@inherits diameter_rfc4005_nasreq +@inherits diameter_rfc4005_nasreq Accounting-Input-Octets Accounting-Output-Octets Called-Station-Id @inherits diameter_rfc4006_cc @inherits diameter_etsi_es283_034 @inherits diameter_3gpp_base diff --git a/dia/diameter_rfc4072.dia b/dia/diameter_rfc4072.dia index ad79346..bec33e2 100644 --- a/dia/diameter_rfc4072.dia +++ b/dia/diameter_rfc4072.dia @@ -25,7 +25,7 @@ @id 1 @inherits diameter_gen_base_rfc6733 -@inherits diameter_rfc4005_nasreq +@inherits diameter_rfc4005_nasreq Callback-Id Callback-Number Called-Station-Id Calling-Station-Id Configuration-Token Connect-Info Framed-AppleTalk-Link Framed-AppleTalk-Network Framed-AppleTalk-Zone Framed-Compression Framed-Interface-Id Framed-IP-Address Framed-IP-Netmask Framed-IPv6-Pool Framed-IPv6-Prefix Framed-IPv6-Route Framed-IPX-Network Framed-MTU Framed-Pool Framed-Protocol Framed-Route Framed-Routing Filter-Id Idle-Timeout NAS-Filter-Rule NAS-Identifier NAS-IP-Address NAS-IPv6-Address NAS-Port NAS-Port-Id NAS-Port-Type Originating-Line-Info Port-Limit QoS-Filter-Rule Reply-Message Service-Type State Tunneling ;; =========================================================================== -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41015?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ibc11180489db6d86819ab17a5e7e92636dfed95e Gerrit-Change-Number: 41015 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>