Attention is currently required from: jolly. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38514?usp=email ) Change subject: Indicate errior and release BSS connection when SMS transaction fails ...................................................................... Patch Set 1: (1 comment) File src/libmsc/gsm_04_11.c: https://gerrit.osmocom.org/c/osmo-msc/+/38514/comment/a4ff7017_c2c570e8?usp… : PS1, Line 1340: MSC_A_USE_CM_SERVICE_SMS We need to be careful here. SMS can be sent (and received) during an ongoing voice/data call. I don't remember if `CM SERVICE REQUEST` for MO SMS is sent during a voice call, we need to check this before merging this patch. Otherwise we may put a non-existing token and segfault here. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38514?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I82da9c283205c69b19ceb4ba40ac5aa7f37d159b Gerrit-Change-Number: 38514 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 24 Oct 2024 09:18:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No