Attention is currently required from: osmith.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-sip-connector/+/32018 )
Change subject: sip: log release caused by status >= 300 as error
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
But isn't it an error? it's not successful,
that would be 2xx. […]
I'm fine with ERROR too, but usually ERROR is for
unexpected stuff in the program or in the protocol, not for something which is expected to
happen maybe. No strong opinion I was just sharing the concern, I'm fine with it.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-sip-connector/+/32018
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I64889d6ce174dc17d44d85aac12e7ee6e6b06164
Gerrit-Change-Number: 32018
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 22 Mar 2023 14:39:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment