Attention is currently required from: neels, pespin.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35175?usp=email )

Change subject: mgcp_network: Improve err logging when rtp pkt from unexpected origin comes in ......................................................................

Patch Set 1: Code-Review+1

(2 comments)

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/35175/comment/f32e904e_b7b92c95 PS1, Line 873: osmo_sockaddr_to_str(addr), osmo_sockaddr_ntop(&conn->end.addr.u.sa, ipbuf));

I used osmo_sockaddr_ntop on purpose since we are only interested about the wrong IP address there, […]

Done

https://gerrit.osmocom.org/c/osmo-mgw/+/35175/comment/ff06a5b8_4af3fca2 PS1, Line 885: osmo_sockaddr_to_str(addr), osmo_sockaddr_port(&conn->end.addr.u.sa),

It's printing the port of *another* address. See the check between "got" and "expected" there. […]

Done