Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853 ) Change subject: pgw: Initial Gy support ...................................................................... Patch Set 2: (2 comments) File pgw/PGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853/comment/4893f33e_5b2d… PS2, Line 320: Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, Let's keep setverdict() separate from f_shutdown(), so that there is no need to use log2str(). https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853/comment/67a668ed_2f64… PS2, Line 348: Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, Let's keep setverdict() separate from f_shutdown(), so that there is no need to use log2str(). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I04cf78cb4bc73de59f803c01208a7ef9056cb14f Gerrit-Change-Number: 27853 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Apr 2022 22:36:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment