laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/28482 )
Change subject: mgcp-client: Remove impossible code path ......................................................................
mgcp-client: Remove impossible code path
read(4096 - 128) cannot return > 4096 - 128.
Change-Id: I352c3b28c8de6482277cb84cd0f51893494dc929 --- M src/libosmo-mgcp-client/mgcp_client.c 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved
diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index 3711f24..77de23f 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -726,10 +726,6 @@
msgb_free(msg); return -1; - } else if (ret > 4096 - 128) { - LOGPMGW(mgcp, LOGL_ERROR, "Too much data: %s: %d\n", osmo_sock_get_name2(fd->fd), ret); - msgb_free(msg); - return -1; }
msg->l2h = msgb_put(msg, ret);
-
laforge