neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35434?usp=email ) Change subject: add fmtp.h ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: The intention was to only do fmtp specific things, but i feel a tendency here to absorb also other parts of SDP formatting. Maybe instead of making this file public API as "fmtp.h", we should combine this with the generic SDP parsing code that currently lives in osmo-msc.git and publish it as "sdp.h" instead? (It might then even go on to replace the current SDP parsing code in osmo-mgw.git, but not required.) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35434?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3eaea353dbd98c19212199b564342d0ac16cbc07 Gerrit-Change-Number: 35434 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sat, 23 Dec 2023 06:32:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment