Attention is currently required from: lynxis lazus.
Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email )
Change subject: ccid: fix rdr_to_pc_parameters and rdr_to_pc_hardware_error ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157/comment/4d907793_f77... : PS1, Line 8:
What is wrong? "The messages in the spec were different. […]
It is not really important because this was never working and the rdr_to_pc_parameters is pointless because we ignore the set message anyway and never change any parameters, so it was basically "working fine" since the octsim was created despite being wrong, and we do not have any bug reports about weird cards that don't work either. This just aligns it with the spec, that's it.