[S] Change in osmo-ttcn3-hacks[master]: RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack - gerrit-log

10 Dec 2024


      Attention is currently required from: fixeria, lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email )
Change subject: RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File library/RAW_NS.ttcnpp:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063/comment/2e5d435d_3ccce... :
PS4, Line 512: 		if (isvalue(cause) and valueof(cause) == NS_CAUSE_UNKNOWN_IP_ENDPOINT) {
@vyanitskiy@sysmocom.de is "isvalue()" working fine here or should "ispresent()" be used? I always find confusing what each of those returns in each scenario...
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I18c659e43db79400c1b428ed745267a5e6e59102
Gerrit-Change-Number: 39063
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Comment-Date: Tue, 10 Dec 2024 12:06:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes