Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/29572
)
Change subject: osmux: Log remote address upon rx of osmux pkt
......................................................................
Patch Set 1:
(1 comment)
File src/common/osmux.c:
https://gerrit.osmocom.org/c/osmo-bts/+/29572/comment/0803a820_707a7a2a
PS1, Line 267: osmo_sockaddr_to_str_buf
Why not just using osmo_sockaddr_to_str()?
Just
kept the code similar to osmo-mgw, which is (will be) multithreaded. there's nothing
wrong with using the _buf counterpart.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/29572
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I391bc02a16eae1602680cb96128252f262852e14
Gerrit-Change-Number: 29572
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Oct 2022 12:13:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment