Attention is currently required from: falconia.

pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42197?usp=email )

Change subject: RTP: make ortp optional at compile time ......................................................................

Patch Set 2:

(3 comments)

Patchset:

PS2: I see these 2 ORTP references, but they are probably wrong and can be dropped since they should come from libosmo-netif pkgcfg if needed:

src/osmo-bts-oc2g/Makefile.am 17: $(ORTP_CFLAGS) \ 29: $(ORTP_LIBS) \

Do you mind submitting an extra patch dropping them? I can do it myself but I don't want to interfere with your changes.

File contrib/ber/Makefile.am:

https://gerrit.osmocom.org/c/osmo-bts/+/42197/comment/71258ed1_67d4e696?usp=... : PS2, Line 1: if ENABLE_ORTP Add this to the parent Makefile to conditionally add it to SUBDIR so this file is not even processed?

File src/common/bts.c:

https://gerrit.osmocom.org/c/osmo-bts/+/42197/comment/7c27856c_c8f7bf61?usp=... : PS2, Line 406: { you don't really need {} afaict, we are enforcing -std=gnu11 during build in configure.ac?