Attention is currently required from: laforge, neels, pespin.

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email )

Change subject: ecu: force alignment of member data in struct osmo_ecu_state ......................................................................

Patch Set 6:

(1 comment)

File src/codec/ecu_fr.c:

https://gerrit.osmocom.org/c/libosmocore/+/35212/comment/204ef9d4_51209530 PS5, Line 315: struct fr_ecu_state *fr = (struct fr_ecu_state *) st;

Here and in the function below is where you need container_of: […]

Thanks. I have added this now as suggested, but I still do not understand where the advantage is. container_of gets st, which is of type osmo_ecu_state but when calling container_of we specify it as struct fr_ecu_state. And we request the container address of the member ecu_state, which is struct fr_ecu_state. I see that this works but I do not see any practical advantage. We still need to have the ecu_state member in struct fr_ecu_state.