Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34902?usp=email ) Change subject: filesystem: add flag to tell whether an ADF supports an FS or not ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Unfortunately I could not find any hard evidence on this but I think you are right here. Probably applications which do not support a file system won't have an ADF. The only reason why one would want to have an ADF despite this is that an ADF would allow the selection of the application via a 2 byte FID. This probably also means that it is incorrect to have the ADF.ARA-M in the file system tree at all. However, it is a very handy extension to have such virtual ADFs. So what would speak against having the proposed has_fs flag that tells pySim that there is no FS behind this ADF? If we want to express this in the class model we could have a CardObj that is above CardFile and has the most basic methods and properties that are not file system related in particular. Then We could create a new type of CardADF that directly inherits from CardObj. We could call it "CardAPP". We would still make those appear in the file system tree but with a name that makes clear that it is a normal card applet without file system support. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34902?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifd0f7c34164685ea18d8a746394e55416fa0aa66 Gerrit-Change-Number: 34902 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 02 Nov 2023 10:25:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment