Attention is currently required from: arehbein, laforge.

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35073?usp=email )

Change subject: port from osmo_stream_*_get_ofd() to osmo_stream_srv_get_fd() ......................................................................

Patch Set 2: Code-Review+1

(2 comments)

File src/osmo_ss7_asp.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/35073/comment/3ec83c43_196abe23 PS1, Line 846: asp->sock_name = osmo_sock_get_name(asp, fd);

`osmo_sock_get_name_buf()` (which will be called) does check for `fd < 0`, not sure if we also want […]

Done

https://gerrit.osmocom.org/c/libosmo-sccp/+/35073/comment/663f118a_5127442b PS1, Line 915: return ipa_rx_msg(asp, msg, fd & 0xf);

no, not problematic at all. […]

I was also a bit puzzled when reading this and just assumed something like that was happening.