Attention is currently required from: arehbein, laforge.

Patch set 2:Code-Review +1

View Change

2 comments:

• File src/osmo_ss7_asp.c:

  • Patch Set #1, Line 846: asp->sock_name = osmo_sock_get_name(asp, fd);

    `osmo_sock_get_name_buf()` (which will be called) does check for `fd < 0`, not sure if we also want […]

    Done

  • Patch Set #1, Line 915: return ipa_rx_msg(asp, msg, fd & 0xf);

    no, not problematic at all. […]

    I was also a bit puzzled when reading this and just assumed something like that was happening.

To view, visit change 35073. To unsubscribe, or for help writing mail filters, visit settings.