Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40973?usp=email )
Change subject: iu_rnc: Split iu_rnc_register API into 2 steps ......................................................................
Patch Set 1:
(2 comments)
File src/sgsn/gprs_ranap.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40973/comment/71031275_b6739d95?usp... : PS1, Line 377:
empty newline.
Done
File src/sgsn/iu_rnc.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40973/comment/3c9f52f6_dc34496a?usp... : PS1, Line 80: if (rnc) {
(I don't know SCCP very well). […]
Yes good point, I didn't think about that scenario with hnbgw. I'll need to take that into account when improving the existing code, since that's something different from other programs eg. osmo-msc.
In any case afaiu I'm not really changing any existing logic in this commit. But I agree the existing logic may be flawed.
-
pespin