Attention is currently required from: pespin, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34192 ) Change subject: pcuif_proto: use confirmation flag in struct gsm_pcu_if_pch ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34192/comment/0cb4d8e8_9c9c2240 PS1, Line 552: if (pch->confirmed_imm_ass) * What happens if using a newer osmo-bsc with an older osmo-pcu which does not send the field? (see https://gerrit.osmocom.org/c/osmo-bts/+/34191/comments/2ac37623_217744e6) * This also makes me think naming it just imm_ass in the struct makes more sense, and commenting on the struct that it is for both paging and imm ass, see my comment here: https://gerrit.osmocom.org/c/osmo-pcu/+/34190/comments/5a0bbabc_378328a0 (but given that I'm not so familiar with the code, maybe there's a good reason to not do this?) Otherwise LGTM. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34192 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3d2842626b7e8325860ea3160c7d900d39e953a0 Gerrit-Change-Number: 34192 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Aug 2023 13:36:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment