pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26806 )
Change subject: ran_msg_iu.c: Set proper codec in Assignment Complete ......................................................................
ran_msg_iu.c: Set proper codec in Assignment Complete
We need to set the codec as present in order for msc_a_up_call_assignment_complete() to configure properly the CN-side of he leg with the IUFP codec, which should be the desired default in order to avoid transcoding.
Change-Id: Ib8086462239e2df748cf47ea7b37a07f1f3b85a8 --- M src/libmsc/ran_msg_iu.c 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/06/26806/1
diff --git a/src/libmsc/ran_msg_iu.c b/src/libmsc/ran_msg_iu.c index c10df4d..ee1d0a5 100644 --- a/src/libmsc/ran_msg_iu.c +++ b/src/libmsc/ran_msg_iu.c @@ -153,7 +153,8 @@ .msg_type = RAN_MSG_ASSIGNMENT_COMPLETE, .msg_name = "RANAP RAB Assignment Response", .assignment_complete = { - .codec = CODEC_AMR_8000_1, + .codec_present = true, + .codec = CODEC_IUFP, }, }; if (osmo_sockaddr_str_from_str(&ran_dec_msg->assignment_complete.remote_rtp, addr, port)) {
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26806 )
Change subject: ran_msg_iu.c: Set proper codec in Assignment Complete ......................................................................
Patch Set 1: Code-Review+1
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26806 )
Change subject: ran_msg_iu.c: Set proper codec in Assignment Complete ......................................................................
Patch Set 1: Code-Review+2
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26806 )
Change subject: ran_msg_iu.c: Set proper codec in Assignment Complete ......................................................................
ran_msg_iu.c: Set proper codec in Assignment Complete
We need to set the codec as present in order for msc_a_up_call_assignment_complete() to configure properly the CN-side of he leg with the IUFP codec, which should be the desired default in order to avoid transcoding.
Change-Id: Ib8086462239e2df748cf47ea7b37a07f1f3b85a8 --- M src/libmsc/ran_msg_iu.c 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve dexter: Looks good to me, approved
diff --git a/src/libmsc/ran_msg_iu.c b/src/libmsc/ran_msg_iu.c index c10df4d..ee1d0a5 100644 --- a/src/libmsc/ran_msg_iu.c +++ b/src/libmsc/ran_msg_iu.c @@ -153,7 +153,8 @@ .msg_type = RAN_MSG_ASSIGNMENT_COMPLETE, .msg_name = "RANAP RAB Assignment Response", .assignment_complete = { - .codec = CODEC_AMR_8000_1, + .codec_present = true, + .codec = CODEC_IUFP, }, }; if (osmo_sockaddr_str_from_str(&ran_dec_msg->assignment_complete.remote_rtp, addr, port)) {
-
dexter -
laforge
-
pespin