Change in libosmo-netif[master]: osmux: Allocate struct osmux_out_handle through API - gerrit-log

4 Oct 2022


      Attention is currently required from: pespin, fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29528 )
Change subject: osmux: Allocate struct osmux_out_handle through API
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/osmux_input.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/29528/comment/c0549b4c_80e70a05 
PS1, Line 737: /* DEPRECATED: Use talloc_free() instead (will call osmux_xfrm_input_talloc_destructor()) */
...
I chose to use a talloc destructor because it makes it easier to destroy the object when the parent  […]
Pau's reasoning makes sense to me here.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29528
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I752ab031f935f04731bb1a354333f1682a1aa5bd
Gerrit-Change-Number: 29528
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Tue, 04 Oct 2022 09:33:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin pespin@sysmocom.de
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Gerrit-MessageType: comment