Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27430 )

Change subject: osmo-bts-trx: rx_tchh_fn(): fix HR SID detection (wrong offset) ......................................................................

Patch Set 4:

(1 comment)

File src/osmo-bts-trx/sched_lchan_tchh.c:

https://gerrit.osmocom.org/c/osmo-bts/+/27430/comment/8b57047f_f8ea03c6 PS4, Line 151: /* gsm0503_tch_hr_decode() prepends an additional 0x00 octet, skip it */

I see gsm0503_tch_hr_decode() is also used in osmocom-bb trxcon. Maybe tha talso needs fix? […]

I see all decode functions seem to have a first byte prefixed in a specific way: libosmocore/tests/coding/coding_test.c main()

uint8_t test_speech_fr[33]; uint8_t test_speech_efr[31]; uint8_t test_speech_hr[15];

for (i = 0; i < len_l2; i++) test_sch(test_l2[i]);

for (i = 0; i < sizeof(test_speech_fr); i++) test_speech_fr[i] = i; test_speech_fr[0] = 0xd0; test_fr(test_speech_fr, sizeof(test_speech_fr));

for (i = 0; i < sizeof(test_speech_efr); i++) test_speech_efr[i] = i; test_speech_efr[0] = 0xc0; test_fr(test_speech_efr, sizeof(test_speech_efr));

for (i = 0; i < len_l2; i++) test_fr(test_l2[i], sizeof(test_l2[0]));

for (i = 0; i < sizeof(test_speech_hr); i++) test_speech_hr[i] = i * 17; test_speech_hr[0] = 0x00; test_hr(test_speech_hr, sizeof(test_speech_hr));

for (i = 0; i < len_l2; i++) test_hr(test_l2[i], sizeof(test_l2[0]));