Attention is currently required from: dexter, laforge, neels.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email )

Change subject: ecu: force alignment of member data in struct osmo_ecu_state ......................................................................

Patch Set 2: Code-Review-1

(1 comment)

Patchset:

PS2: I think your comments are still not refuting my feedback on the fact that using the data[] array to put private fields is probably not a good idea, and that the private code extending it (adding fields) should be using a private struct which encloses the public one as a field, then use offsetof() and container_of() and all that.

So, in summary, I still believe we should fix the private/sublcass code, not the public one, which on top breaks the ABI.