Attention is currently required from: dexter, laforge, neels.

Patch set 2:Code-Review -1

View Change

1 comment:

• Patchset:

  • Patch Set #2:

    I think your comments are still not refuting my feedback on the fact that using the data[] array to put private fields is probably not a good idea, and that the private code extending it (adding fields) should be using a private struct which encloses the public one as a field, then use offsetof() and container_of() and all that.

    So, in summary, I still believe we should fix the private/sublcass code, not the public one, which on top breaks the ABI.

To view, visit change 35212. To unsubscribe, or for help writing mail filters, visit settings.