Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36031?usp=email )
Change subject: kernel-gtp: support IPv6 on outer layer ......................................................................
Patch Set 1:
(4 comments)
File gtp/gsn.c:
https://gerrit.osmocom.org/c/osmo-ggsn/+/36031/comment/9f8da66d_47daf4f8 PS1, Line 424: int domain = in46a_to_af(listen);
can we call it family at some point? I had to fiugre out what "domain" meant here.
Done
https://gerrit.osmocom.org/c/osmo-ggsn/+/36031/comment/4fd38ec8_0e2f286c PS1, Line 446: addr.sin_len = sizeof(struct addr);
wrong indentation.
Done
https://gerrit.osmocom.org/c/osmo-ggsn/+/36031/comment/c06f2cf8_41fe7af2 PS1, Line 461: if (bind(*fd, &addr, sizeof(addr)) < 0)
the bind can be deduplicated by moving it below.
Done
File tests/gtp/Makefile.am:
https://gerrit.osmocom.org/c/osmo-ggsn/+/36031/comment/78e1273a_c962488f PS1, Line 25: $(top_builddir)/lib/libmisc.a \
why is this libmisc needed here now?
Because gsn.c and gtp.c use functions from in46a now, not having libmisc.a leads to undefined reference errors.
-
osmith