Attention is currently required from: daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33495 ) Change subject: osmo_io: Use bitfield for various boolean flags ...................................................................... Patch Set 1: (5 comments) File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/33495/comment/00f0ecf1_9532519a PS1, Line 39: iofd `(iofd)->flags`, just to be safe https://gerrit.osmocom.org/c/libosmocore/+/33495/comment/894f5fdc_aa7899e1 PS1, Line 40: } while (0) Agreeing with the linter, do-while wrapper is not really needed here. https://gerrit.osmocom.org/c/libosmocore/+/33495/comment/53c7ca3a_9c7146f7 PS1, Line 47: iofd->flags & flag same here: `(iofd)->flags & (flag)` https://gerrit.osmocom.org/c/libosmocore/+/33495/comment/02433da4_e8289139 PS1, Line 58: TODO: Move to bitfield remove this TODO? File src/core/osmo_io_poll.c: https://gerrit.osmocom.org/c/libosmocore/+/33495/comment/a6cc2654_bae1cdec PS1, Line 84: FLAG_ISSET missing `IOFD_` prefix -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33495 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic134e4c8d791c34778202fea98a70bc04007a113 Gerrit-Change-Number: 33495 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Jun 2023 09:27:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment