Attention is currently required from: pespin.
falconia has posted comments on this change by falconia. (
https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email )
Change subject: bring twjit into libosmo-netif
......................................................................
Patch Set 5:
(3 comments)
File src/twjit.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/4f683d70_f4820a8… :
PS2, Line 157: config->thinning_int = 17;
AFAICT the only similarity between my algorithm and
CoDel is that both algos sometimes "artificially […]
Can this point be marked
as resolved?
File src/twjit.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/792ea0c4_ee9a92a… :
PS3, Line 331: static void analytics_cont(struct osmo_twjit *twjit, uint16_t rx_seq,
Not necessarily in perfect order, just same SSRC. […]
Can this point be marked as resolved?
File src/twjit_vty.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/8911bc55_90e97c7… :
PS2, Line 41: vty_out(vty, "%s%s%s", prefix, name ? : "twjit",
VTY_NEWLINE);
I think it may be easier having it as total prefix,
but not a hard blocker here.
Can this point be marked as resolved?
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658
Gerrit-Change-Number: 39280
Gerrit-PatchSet: 5
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Aug 2025 05:44:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>