Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email ) Change subject: RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File library/RAW_NS.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063/comment/1695852d_ab2d… : PS4, Line 512: if (isvalue(cause) and valueof(cause) == NS_CAUSE_UNKNOWN_IP_ENDPOINT) { `ispresent()` is suitable for matching templates that can be `?`/`*`, but here `cause` is restricted to `(omit)` (a value or `omit`), so `isvalue()` is fine here. You could also do it like this: `match(cause, NS_CAUSE_UNKNOWN_IP_ENDPOINT)`, but I am fine either way. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18c659e43db79400c1b428ed745267a5e6e59102 Gerrit-Change-Number: 39063 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 10 Dec 2024 14:11:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>