Attention is currently required from: lynxis lazus, pespin.

fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email )

Change subject: RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack ......................................................................

Patch Set 4: Code-Review+2

(1 comment)

File library/RAW_NS.ttcnpp:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063/comment/1695852d_ab2db... : PS4, Line 512: if (isvalue(cause) and valueof(cause) == NS_CAUSE_UNKNOWN_IP_ENDPOINT) {

the ttcn3 cheat sheet says it's only for record/unions.

`ispresent()` is suitable for matching templates that can be `?`/`*`, but here `cause` is restricted to `(omit)` (a value or `omit`), so `isvalue()` is fine here.

You could also do it like this: `match(cause, NS_CAUSE_UNKNOWN_IP_ENDPOINT)`, but I am fine either way.