Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38964?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: PCUIF: fix usage of bts number in PCUIF_TXT_IND ...................................................................... PCUIF: fix usage of bts number in PCUIF_TXT_IND When we receive the PCU_VERSION using tr_PCUIF_TXT_IND we must ignore the included BTS number because the PCU_VERSION is not addressed to a specific BTS. When we send a PCU_VERSION using ts_PCUIF_TXT_IND, we should always use the bts number 0 to be consistent (the BSC/BTS will ignore this number anyway). Let's fix the usage of tr_PCUIF_TXT_IND and put comments, to make clear why the above applies. Change-Id: I93de261fc77806b2f817e0d30cb1b0d377ed0dbb related: OS#6507 --- M bts/BTS_Tests.ttcn M bts/BTS_Tests_OML.ttcn M pcu/PCUIF_Components.ttcn M pcu/PCU_Tests_NS.ttcn 4 files changed, 10 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/64/38964/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38964?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I93de261fc77806b2f817e0d30cb1b0d377ed0dbb Gerrit-Change-Number: 38964 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>