[XS] Change in libosmocore[master]: gprs: define OSMO_RESERVED_RAC 0xff - gerrit-log

17 Feb 2025


      Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/39557?usp=email )
Change subject: gprs: define OSMO_RESERVED_RAC 0xff
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File include/osmocom/gsm/protocol/gsm_04_08_gprs.h:
https://gerrit.osmocom.org/c/libosmocore/+/39557/comment/e92e8448_e6df1eb2?u... :
PS1, Line 14: #define OSMO_RESERVED_RAC 0xff
I wonder why is this marked as "osmocom specific". I guess because you didn't find an exact spec reference stating so? maybe add a "TODO: find spec ref" instead of "osmocom specific"?
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39557?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I17a2adedc2c2ab158f40d58280f5df5c6967b8ec
Gerrit-Change-Number: 39557
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Comment-Date: Mon, 17 Feb 2025 10:09:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes