Attention is currently required from: laforge, pespin.

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email )

Change subject: HTTP_Adapter: allow API users to specifiy custom header ......................................................................

Patch Set 5:

(3 comments)

File library/HTTP_Adapter.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/ca8eb4c0_68f6f... PS3, Line 73: var HeaderLines hdr := { };

You can turn this into a "var template (value) Headerlines hdr := {};"

I am not sure if that really works. I have tried that out, but I get an error: "error: Reference to a value was expected instead of template variable `hdr'" (line 77, where the concatenation happens) maybe the concatenation needs a value rather than a template?

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/bbfd7a33_0e1d3... PS3, Line 77: hdr := hdr & {valueof(ts_HeaderLine("Host", valueof(host)))};

...so you don't need to do valueof() each time.

(see above, I removed the valueof as suggested)

File library/HTTP_Adapter.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/89986111_5fc1b... PS4, Line 57: h

indent issue (tab missing)

Done