Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27722 )

Change subject: osmo-bts-trx: rx_tchh_fn(): use a lookup table for FACCH/H ......................................................................

Patch Set 1: Code-Review+2

(1 comment)

File src/osmo-bts-trx/sched_lchan_tchh.c:

https://gerrit.osmocom.org/c/osmo-bts/+/27722/comment/c2ac8cf9_c77c14ba PS1, Line 85: int fn_is_odd = (((bi->fn + 26 - 10) % 26) >> 2) & 1;

iiuc the "fn_is_odd" before was actually wrong, at least in the naming, since it's no only checking […]

Yes, this naming looks weird to me too. 'fn_is_facch' would have been a lot cleaner. But in reality this flag is true when no FACCH is possible at the given TDMA FN, so then 'fn_is_not_facch'. So yeah, with a lookup table it's a lot cleaner.