[XS] Change in osmo-trx[master]: comma_delimited_to_vector() optimization CID#465430 - gerrit-log

20 Jan 2025


      Attention is currently required from: Hoernchen, neels.
fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-trx/+/39359?usp=email )
Change subject: comma_delimited_to_vector() optimization CID#465430
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-trx/+/39359/comment/15761bdc_2aa9559d?usp=... :
PS1, Line 9: (I
The patch looks good. Moving is "cheaper" than copying. See https://lemire.me/blog/2023/01/30/move-or-copy-your-strings-possible-perform..., for instance.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/39359?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I30e57c6a9df39552bc4f8c18d27bc421f5c60f49
Gerrit-Change-Number: 39359
Gerrit-PatchSet: 1
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Hoernchen ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-Attention: Hoernchen ewild@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Comment-Date: Mon, 20 Jan 2025 12:57:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes