Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-pcap/+/39173?usp=email )
Change subject: pcap-client: Move stats to its own file
......................................................................
Patch Set 2:
(2 comments)
File include/osmo-pcap/osmo_pcap_client.h:
https://gerrit.osmocom.org/c/osmo-pcap/+/39173/comment/328ab446_459e0963?us… :
PS2, Line 34: struct rate_ctr_group;
can be removed
Done
File src/osmo_client_stats.c:
https://gerrit.osmocom.org/c/osmo-pcap/+/39173/comment/83a12efc_bce5dfe4?us… :
PS2, Line 29: #include <osmocom/vty/logging.h>
: #include <osmocom/vty/telnet_interface.h>
: #include <osmocom/vty/stats.h>
: #i
There's no VTY stuff in this file, so drop these?
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcap/+/39173?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I4b5ecdd6f9b0c646dd03ca3bc7fa24624fb9fcbc
Gerrit-Change-Number: 39173
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 24 Dec 2024 14:36:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>