Attention is currently required from: fixeria.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32641 )

Change subject: fix use-after-free in ipaccess_bts_keepalive_fsm_alloc() ......................................................................

Patch Set 1: Code-Review+1

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/libosmo-abis/+/32641/comment/c5c6e5a5_2a2d334d PS1, Line 31: *** (!) as well as the struct osmo_fsm_inst (talloc child) shouldn't the fsm always be freed with explicit osmo_fsm_inst_free() and not through automatic talloc_free()?

https://gerrit.osmocom.org/c/libosmo-abis/+/32641/comment/d60ea2fb_ef7535b8 PS1, Line 33: *** calling ipaccess_keepalive_fsm_cleanup() why is cleanup() called here if it was freed above? why wasn't the pointer set to NULL?