Attention is currently required from: fixeria.

Patch set 1:Code-Review +1

View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 31: *** (!) as well as the struct osmo_fsm_inst (talloc child)

    shouldn't the fsm always be freed with explicit osmo_fsm_inst_free() and not through automatic talloc_free()?

  • Patch Set #1, Line 33: *** calling ipaccess_keepalive_fsm_cleanup()

    why is cleanup() called here if it was freed above? why wasn't the pointer set to NULL?

To view, visit change 32641. To unsubscribe, or for help writing mail filters, visit settings.