Attention is currently required from: laforge, fixeria, pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33634 )
Change subject: S1AP_Templates: fix tr_S1AP_SetupResp
......................................................................
Patch Set 1:
(1 comment)
File library/s1ap/S1AP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33634/comment/111d34ec_ca98…
PS1, Line 116: *, {
> Like in the preceding patch, there is only one
*optional* `MME Name` IE. […]
I wonder if it is wise to match the IEs in any order.
Usually one has to obey the order that that the spec dictates. Shouldn't we be strict
about the order?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33634
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I07513743142f519481530801d4e1185d55f6ea4b
Gerrit-Change-Number: 33634
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Jul 2023 10:28:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment