Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29285 )
Change subject: Introduce Osmux support ......................................................................
Patch Set 2:
(7 comments)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/4b428dbf_42e8cabe PS1, Line 1624: {
cosmetic: no need for curly braces here
Done
File src/common/osmux.c:
https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/6bfbe15a_ea09399b PS1, Line 1: libosmocore logging support
copy-paste
Done
https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/35543022_a8a72b26 PS1, Line 43: (OSMUX_CID_MAX + 1 + 7) / 8
OSMO_BYTES_FOR_BITS(OSMUX_CID_MAX + 1)
Done
https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/7e3077eb_9f13fbc2 PS1, Line 47: ()
void
Done
https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/a6ecb8bd_3ca49764 PS1, Line 183: osmux_handle_lookup
_find_or_create() better reflects what this function does.
Done
https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/d0d28051_ba07abbf PS1, Line 234: /* TS0..3 */
This is not true, remove this comment.
Done
https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/f518c94a_f18c4057 PS1, Line 293: not needed?
This needs to be resolved before merging this change, or at least marked as FIXME.
Done
-
fixeria