Attention is currently required from: pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ci/+/28415
)
Change subject: jobs/osmocom-obs: run against
obs.osmocom.org too
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
This looks a bit too dark. […]
* This way it
can't be forgotten when changing code that uses osc. It may work with one server that
a developer is testing with, but then fail later on when we would need to use the other
server.
* I think using 'osc -A "$OBS_SERVER"' instead of 'osc'
everywhere makes the code less readable. If you insist on not using alias, I'd rather
put that into $OSC and call that. (But for the first reason I think alias is better.)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ci/+/28415
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ib271e16e93ebc58ed1ecb0ea881e1f1370e40928
Gerrit-Change-Number: 28415
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Jun 2022 14:06:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment