Attention is currently required from: fixeria, laforge, pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39731?usp=email )
Change subject: trau: new function osmo_trau2rtp_ufe() ......................................................................
Patch Set 3:
(6 comments)
File src/trau/trau_rtp_conv.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/6a3ce467_8ca4cfa5?... : PS2, Line 249: * \param[in] emit_twts002 self-explanatory
Same, not self-explanatory.
Resolved in https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/70624bbd_9a2f4402/
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/76427d24_2399df94?... : PS2, Line 260: return -EINVAL;
ufe is left uninitialized here.
Resolved in https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/27668a3c_341e3e03/
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/79964b5b_52570e92?... : PS2, Line 263: return -ENOSPC;
ufe is left uninitialized here.
Resolved in https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/27668a3c_341e3e03/
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/8d205de4_d46e5e2b?... : PS2, Line 282: return 0;
ufe is left uninitialized here.
Resolved in https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/27668a3c_341e3e03/
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/e0b85775_06dd7f62?... : PS2, Line 299: return 1;
ufe is left uninitialized here.
Resolved in https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/27668a3c_341e3e03/
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/5bd84693_5f4a66bf?... : PS2, Line 311: return GSM_HR_BYTES_RTP_RFC5993;
ufe is left uninitialized here.
Resolved in https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/27668a3c_341e3e03/
-
falconia