Attention is currently required from: laforge, fixeria.

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979 )

Change subject: ASCI: Add tests for voice group/broadcast calls at MSC ......................................................................

Patch Set 2:

(3 comments)

File msc/MSC_Tests_ASCI.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979/comment/2cdb63d4_dcbf5... PS1, Line 50: type integer ASCI_TEST; : const ASCI_TEST ASCI_TEST_NO_CALLREF := 1; : const ASCI_TEST ASCI_TEST_SETUP_REFUSE := 2; : const ASCI_TEST ASCI_TEST_ASSIGN_FAIL := 3; : const ASCI_TEST ASCI_TEST_COMPLETE_VGCS := 4; : const ASCI_TEST ASCI_TEST_COMPLETE_VBS := 5;

one could also simply add the new enum type as something that can be sent over the existing port coo […]

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979/comment/69fbea98_28955... PS1, Line 58: type component asci_CT extends MTC_CT {

Just a friendly note (not critical): it's better to mark module-local types, altsteps, and functions […]

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979/comment/b0822e86_44c54... PS1, Line 65: const charstring COORD_SETUP := "SETUP";

full ack

Done