Attention is currently required from: laforge, osmith.

Hello Jenkins Builder, laforge, osmith,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/35171?usp=email

to look at the new patch set (#3).

The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder

Change subject: soft_uart: check Rx/Tx state once in osmo_soft_uart_{rx,tx}_ubits() ......................................................................

soft_uart: check Rx/Tx state once in osmo_soft_uart_{rx,tx}_ubits()

Check it once rather than doing this in a loop. Return -EAGAIN if Rx or Tx is not enabled when calling osmo_soft_uart_{rx,tx}_ubits().

This [theoretically] improves performance by reducing the number of conditional statements in loops. In the Tx path, this also prevents calling the .tx_cb() when the transmitter is disabled, so that we don't loose the application data.

Change-Id: I70f93b3655eb21c2323e451052c40cd305c016c8 Related: OS#4396 --- M src/core/soft_uart.c M tests/soft_uart/soft_uart_test.c 2 files changed, 36 insertions(+), 8 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/71/35171/3