Attention is currently required from: laforge.
dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41734?usp=email )
Change subject: esim.saip.FsProfileElement: Add file2pe() for single file conversion ......................................................................
Patch Set 4: Code-Review-1
(2 comments)
Patchset:
PS4: I accidentally pushed a change (Iae55485c5ec7763aa4aaa25fd1910b854adaab60) on top of this branch, I am sorry for the inconvenience that may be caused by this.
File pySim/esim/saip/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/41734/comment/85b83f7d_acea57c5?usp=ema... : PS3, Line 638: self.decoded[f.pe_name] = f.to_tuples()
we could […]
Ah ok. I see. Its intentional. Then option a is probably the preferred one. Maybe a comment that explains that changes might be lost when files2pe is run would be a good idea I think.