Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28046 ) Change subject: Introduce new signal S_NM_RUNNING_CHG and implement it for rcarrier,bbtransc ...................................................................... Patch Set 5: (2 comments) File src/osmo-bsc/nm_bb_transc_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28046/comment/1ccc5aee_35f0f9b6 PS2, Line 56: } the point is if teh function is prefixed nm_obj_* and you don't want to change the function name, then you need to change the first argument so it operates on a nm_obj and not on a gsm_bts_bb_trx. File src/osmo-bsc/nm_rcarrier_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28046/comment/46f90c89_4b4a7a4b PS2, Line 43: static void nm_obj_becomes_enabled_disabled(struct gsm_bts_trx *trx, bool running) then pass some generic object and have the called function use gsm_objclass2obj() to de-reference the object this is all about. It really just looks very wrong to have a function prefix about one thing and then take something else as an argument. Or call it fi_priv_becomes_enabled_disabled, or something else creative. nm_obj is a name that is clearly associated with some kind of NM / OML object (consisting of object class, object instance , ...) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I206d4c7863a77fbab6a600126742a6a6b8fc3614 Gerrit-Change-Number: 28046 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 May 2022 06:19:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment