Attention is currently required from: pespin.

View Change

2 comments:

• File src/osmo-bsc/nm_bb_transc_fsm.c:

  • Patch Set #2, Line 56: }

    IMHO the safeguard is not needed because the code paths calling this function (all in this same file […]

    the point is if teh function is prefixed nm_obj_* and you don't want to change the function name, then you need to change the first argument so it operates on a nm_obj and not on a gsm_bts_bb_trx.

• File src/osmo-bsc/nm_rcarrier_fsm.c:

  • Patch Set #2, Line 43: static void nm_obj_becomes_enabled_disabled(struct gsm_bts_trx *trx, bool running)

    See my other comment. […]

    then pass some generic object and have the called function use gsm_objclass2obj() to de-reference the object this is all about. It really just looks very wrong to have a function prefix about one thing and then take something else as an argument.

    Or call it fi_priv_becomes_enabled_disabled, or something else creative.

    nm_obj is a name that is clearly associated with some kind of NM / OML object (consisting of object class, object instance , ...)

To view, visit change 28046. To unsubscribe, or for help writing mail filters, visit settings.